Skip to content

chore(perf-issues): Add a mention that thresholds can be configured in settings #13741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

chore(perf-issues): Add a mention that thresholds can be configured in settings #13741

merged 1 commit into from
May 16, 2025
+9 −5

Conversation

@leeandher
Copy link
Member

@leeandher leeandher commented May 16, 2025

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented May 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 7:04pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 16, 2025 7:04pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2025 7:04pm

@leeandher leeandher force-pushed the leander/id-630-modify-docs-for-performance-manage-changes branch from c96e4eb to a756a16 Compare May 16, 2025 18:31
@leeandher leeandher marked this pull request as ready for review May 16, 2025 18:32
@leeandher leeandher requested a review from a team May 16, 2025 18:32
@codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 306 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.2MB 312 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 107 bytes 396.48kB 0.03%
../app/platform-redirect/page.js.nft.json 107 bytes 396.39kB 0.03%
../app/sitemap.xml/route.js.nft.json 107 bytes 394.37kB 0.03%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/JIvMoYnyWZDezWgNosugC/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/JIvMoYnyWZDezWgNosugC/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/6toT15oPN2m1YPDbO7TjA/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/6toT15oPN2m1YPDbO7TjA/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@leeandher leeandher merged commit b5bde22 into master May 16, 2025
13 of 14 checks passed
@leeandher leeandher deleted the leander/id-630-modify-docs-for-performance-manage-changes branch May 16, 2025 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roggenkemper roggenkemper roggenkemper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leeandher @roggenkemper